Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Base Windows padding #715

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[FIX] Base Windows padding #715

merged 1 commit into from
Aug 15, 2023

Conversation

cchallu
Copy link
Contributor

@cchallu cchallu commented Aug 7, 2023

  • Added possibility to pad the beginning of time series with zeros of size input_size to handle bugs with short time series.
  • Added padding on the validation step if time series is short.
  • New start_padding_enabled parameter to enable or disable padding defaulted to False.
  • Uni test on the base_windows class to test padding is working.

@cchallu cchallu requested a review from AzulGarza August 7, 2023 21:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cchallu cchallu merged commit 48bd346 into main Aug 15, 2023
11 checks passed
@cchallu cchallu deleted the fix/padding branch August 15, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants