Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Base recurrent valid loss on original scale #721

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

cchallu
Copy link
Contributor

@cchallu cchallu commented Aug 16, 2023

Improved validation loss of recurrent models (BaseRecurrent) to be on the original scale of the data.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@AzulGarza AzulGarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🚀

@cchallu cchallu merged commit 187a1a0 into main Aug 16, 2023
11 checks passed
@cchallu cchallu deleted the fix/recurrent-val-scale branch August 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants