Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Polars .columns produces list rather than Pandas Index #862

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

akmalsoliev
Copy link
Contributor

@akmalsoliev akmalsoliev commented Jan 17, 2024

Fixes the handling of static_df when it's a polars DataFrame.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@akmalsoliev akmalsoliev changed the title [FIX] Polars produces list rather than Pandas Index [FIX] Polars .columns produces list rather than Pandas Index Jan 17, 2024
`get_indexer_raise_missing` required the variable `static_cols` to be
`pd.Index`, this fixes that issue without modification to util package.
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Just a small suggestion

neuralforecast/tsdataset.py Outdated Show resolved Hide resolved
neuralforecast/tsdataset.py Outdated Show resolved Hide resolved
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmoralez jmoralez added the fix label Jan 17, 2024
@jmoralez jmoralez merged commit e075ab8 into Nixtla:main Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants