Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Theta for intermittent series #316

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Conversation

AzulGarza
Copy link
Member

Since the Theta methods use seasonal_decompose, this PR fix the multiplicative seasonality for zero and negative values.

See #315

  • fix: force additive decomposition if data is non positive
  • feat: protect constant time series

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mergenthaler mergenthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergenthaler mergenthaler merged commit b70e5f8 into main Nov 21, 2022
@mergenthaler mergenthaler deleted the fix/theta-inttermitent-series branch November 21, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants