Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dataset and model to make example easier to follow #345

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

MMenchero
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:03Z
----------------------------------------------------------------

In this example, we'll implement time series cross-validation to evaluate model's performance.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:04Z
----------------------------------------------------------------

Include a text justifiyng the imports of the libraries. These import statements are lost in this part of the text.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:05Z
----------------------------------------------------------------

Here would be a better example to import pandas. Something like, we will use M4.... first we will read the library from an URL using pandas.

import pandas as pd

Y_df = pd.read_parquet('https://datasets-nixtla.s3.amazonaws.com/m4-hourly.parquet') # load the data 
Y_df.head() 



@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:06Z
----------------------------------------------------------------

In the next step, you are not instantiating the StatsForecast class. Just calling a .plot method. The plot method does not take all of those parameters.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:07Z
----------------------------------------------------------------

Here is a good place to talk about the StatsForecast class and its inputs.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

mergenthaler commented on 2022-12-01T00:26:08Z
----------------------------------------------------------------

You did not install datasetsforecast or mention what it is. (This will break for a user)


@mergenthaler mergenthaler self-requested a review December 2, 2022 02:12
@mergenthaler mergenthaler merged commit b2b478f into main Dec 2, 2022
@mergenthaler mergenthaler deleted the feat/improve-CrossValidation-nb branch December 2, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants