Ink/ally/text area update #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allymcknight
force-pushed
the
ink/ally/text-area-update
branch
from
74dcfde
to
b79233a
Compare
|
@lukewestby Hey Luke! Tessa and I thought you might be a good person to review this PR given that there's custom element resizing stuff. |
|
@allymcknight Hello! First, one question: since this corrects a previously broken behavior without modifying any APIs, could the change be directly made to TextArea.V3 rather than adding a V4? If that were the case then it seems to me like we wouldn't have to consider the custom element. |
allymcknight
force-pushed
the
ink/ally/text-area-update
branch
from
6e34263
to
961f2a0
Compare
|
@lukewestby sure! mind checking it out now? |
allymcknight
force-pushed
the
ink/ally/text-area-update
branch
from
6aac998
to
71a74b0
Compare
|
@lukewestby ping! |
|
@allymcknight I think Luke is OOO until January 3. Maybe worth re-teambot-ing? |
allymcknight
requested review from
terezka and
BrianHicks
and removed request for
lukewestby and
terezka
BrianHicks
approved these changes
Dec 28, 2018
There was a problem hiding this comment.
looks good!
FYI: the previous upgrade of noredink-ui is blocked in the monolith on this PR: https://github.com/NoRedInk/NoRedInk/pull/22436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the TextArea styling code which prevented the label from changing color upon text area focus.
OUTFOXES
https://www.pivotaltracker.com/story/show/162593210