Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer buttons are hidden in the RTL view #11558

Closed
ShlomoCode opened this issue May 3, 2023 · 9 comments
Closed

Composer buttons are hidden in the RTL view #11558

ShlomoCode opened this issue May 3, 2023 · 9 comments
Assignees
Labels
Milestone

Comments

@ShlomoCode
Copy link

ShlomoCode commented May 3, 2023

NodeBB version

v3.0.0 - https://community.nodebb.org

NodeBB git hash

No response

NodeJS version

No response

Installed NodeBB plugins

No response

Database type

No response

Database version

No response

Exact steps to cause this issue

  1. Enter the user settings and select RTL language, for example Hebrew (he) or Arabic (ar) and save changes
  2. Shrink the size of the browser window a little, something like 80% of the 14" screen
  3. Try creating a new topic or replying to an existing topic

What you expected

No response

What happened instead

The send/discard post buttons are not visible and cannot be clicked.
The topic can only be sent using the keyboard (ctrl + enter)...
Screenshot attached:
CleanShot 2023-05-03 at 18 16 09@2x

Anything else?

No response

@ShlomoCode ShlomoCode added the bug label May 3, 2023
@barisusakli barisusakli self-assigned this May 3, 2023
@barisusakli barisusakli added this to the 3.1.0 milestone May 3, 2023
@ShlomoCode
Copy link
Author

ShlomoCode commented May 3, 2023

Actually the expected behavior is that the writing box will be on the right side of the screen, and not on the left side. Then the button problem will also be solved.
But if I fix it myself with CSS on the right part of the screen, there is another problem - when creating a new theme, part of the width of the category selection box is hidden:
CleanShot 2023-05-03 at 18 31 01@2x

@ShlomoCode
Copy link
Author

@barisusakli Thanks, but some buttons are still hidden (I ran npm i nodebb-theme-harmony@1.0.13):
CleanShot 2023-05-03 at 18 51 06@2x


Additionally, the issue also exists in the Persona theme

@barisusakli
Copy link
Member

Works fine for me on harmony 1.0.14
image

@ShlomoCode
Copy link
Author

@barisusakli Maybe it has to do with screen size?
Mine 14.2" (MacBook Pro)

@ShlomoCode
Copy link
Author

Additionally, the issue also exists in the Persona theme

CleanShot 2023-05-04 at 03 40 58@2x

@ShlomoCode
Copy link
Author

Why is this issue closed? 🤔

@barisusakli
Copy link
Member

Works fine on persona@13.0.62 as well.

image

@ShlomoCode
Copy link
Author

@barisusakli You're right, I had a plugin that messed up the page display 😧
I apologize for bothering you :(
indeed it works properly in both persona and harmony!
One small problem still exists in harmony@1.0.18 that when the side menu is expanded, part of the category selection drop-down menu is hidden by the side bar:

CleanShot.2023-05-05.at.02.39.04.mp4

@barisusakli
Copy link
Member

@ShlomoCode fixed in linked issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants