Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscussionForumPosting microdata invalid according to google #12192

Closed
oplik0 opened this issue Nov 28, 2023 · 0 comments · Fixed by NodeBB/nodebb-theme-harmony#36
Closed

DiscussionForumPosting microdata invalid according to google #12192

oplik0 opened this issue Nov 28, 2023 · 0 comments · Fixed by NodeBB/nodebb-theme-harmony#36
Assignees
Labels
Milestone

Comments

@oplik0
Copy link
Contributor

oplik0 commented Nov 28, 2023

NodeBB version

v3.5.1

NodeBB git hash

No response

NodeJS version

v20.10.0

Installed NodeBB plugins

No response

Database type

MongoDB

Database version

No response

Exact steps to cause this issue

Look into Google Search console or use their rich data tool to directly check a topic, e.g. https://search.google.com/test/rich-results/result/r%2Fdiscussion-forum?id=HeHDbDMe_4T8uXKPIZWRgg

What you expected

For google to correctly parse the structured data

What happened instead

Google throws multiple errors. Primary issues:

  • comment author has invalid name field (should be Text. I think according to spec the URL should be serialized, but I guess Google didn't bother)
  • DiscussionForumPosting is missing datePublished and author fields
  • initial post should have text/image/video specified

There's also a warning for missing url property, and the tool mentiones that optionally comments could be listed in CreativeWork objects.

Anything else?

Even if Google is in the wrong about specs, NodeBB should probably follow Google here...

Related to this forum thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants