Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hook for image post-processing #1463

Closed
cnvo opened this issue May 1, 2014 · 7 comments
Closed

New hook for image post-processing #1463

cnvo opened this issue May 1, 2014 · 7 comments
Assignees
Milestone

Comments

@cnvo
Copy link
Contributor

cnvo commented May 1, 2014

For plugins and anything else that can be made to do things like resizing and manipulation. Right now for example, when you upload a topic image that is 2000x2000, it uploads but doesn't resize so therefore you have a thumbnail that is supposed to be 120x120 but its just scaled down and distorted to fit.

Can be configurable in ACP for topic images for starters.
And perhaps min and max image size in general.

@cnvo cnvo changed the title New hook in image post-processing New hook for image post-processing May 1, 2014
@julianlam julianlam added this to the 0.5.0 milestone May 1, 2014
@julianlam
Copy link
Member

Would be useful as one of our clients currently has users that upload crazy high quality images of wildlife. Would be nice to automatically scale those down to 1080p at most.

@psychobunny
Copy link
Contributor

I was wondering if this hook could be done entirely client side. The most server side should do is crop down the image to a smaller square (ex. 200x200) and then let client side do the work like resizing/moving/adding fancy instagram blurs

?

@akhoury
Copy link
Member

akhoury commented May 1, 2014

@psychobunny can't do on IE8, but if you do not wish to support this feature on old browsers, then you can use canvas to do so. see my comment here

#1069 (comment)

@psychobunny
Copy link
Contributor

Yeah I think it's not the end of the world if that doesn't work on IE8, as long as the picture loads without any post processing it should be okay

@cnvo cnvo changed the title New hook for image post-processing New hook for Image Post-Processing Jun 2, 2014
@cnvo cnvo changed the title New hook for Image Post-Processing New hook for image post-processing Jun 2, 2014
@NodexTech
Copy link

Just a note, it's really bad performance to have the browser size the image...

@cnvo
Copy link
Contributor Author

cnvo commented Jun 4, 2014

He committed and you commented right after the commit almost at the same time. 7d0eb9a

@cnvo
Copy link
Contributor Author

cnvo commented Jun 4, 2014

Thanks Baris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants