Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to edit skin colors #3886

Closed
BSFishy opened this issue Nov 19, 2015 · 8 comments
Closed

ability to edit skin colors #3886

BSFishy opened this issue Nov 19, 2015 · 8 comments

Comments

@BSFishy
Copy link

BSFishy commented Nov 19, 2015

I think it would be cool, but might take a little bit, if you made it so that admins could make custom skins by just changing the colors, and setting if it is a round or square skin, so like the Cerulean skin VS. the Cosmo theme. I know its asking for a bit much, but I think it would look cool. I want a blue based skin(with the background blue, and the navbar blue), but I noticed that it is just Bootwrap skins, so I think this would be a very cool addition.

@Holyphoenix
Copy link

You can easily override css from the admin panel. I'm not against this feature, but would it really be used over easily changing css?

@BSFishy
Copy link
Author

BSFishy commented Nov 19, 2015

That's true, but it would be easier with like a color picker, and recently/commonly used colors.

@sorvani
Copy link
Contributor

sorvani commented Nov 21, 2015

Admins like me would use this feature. I can edit css. I really, really, do not want to.

@julianlam
Copy link
Member

A dedicated skinning manager may be completely out of scope (plugin request?)

But what if core had the ability to modify a given bootstrap skin's variables.less... that might open it up to small changes.

@psychobunny ?

@barisusakli barisusakli changed the title Skins ability to edit skin colors Dec 29, 2015
@locuststar64
Copy link

The problem with the global css changes is that it plays havok with different skins. I would like to be able to create a new skin, ideally based off an existing one so updates would automatically apply. For example, the default theme may use Cyborg + a background image. But if the user selects a different theme, the background image should not apply because it would look terrible.

@pichalite
Copy link
Contributor

@sunsetbrew this commit NodeBB/nodebb-theme-persona@9476854 will help you do that.

this adds a class to the body tag named after the skin used so you can apply updates specific to the skin.

@locuststar64
Copy link

Ooo, that is awesome. So we will see in the next update. :)

@psychobunny
Copy link
Contributor

I think the change @pichalite did + ACP custom CSS panel is good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants