Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected XSS on 404 Page Not found #4192

Closed
HenryHoggard opened this issue Feb 16, 2016 · 2 comments
Closed

Reflected XSS on 404 Page Not found #4192

HenryHoggard opened this issue Feb 16, 2016 · 2 comments

Comments

@HenryHoggard
Copy link

There is a reflected XSS vulnerability when putting Javascript in the following NodeBB URL.
http://forum.tld/user/1<script>alert(1)</script>

@julianlam
Copy link
Member

https://community.nodebb.org/user/1%3Cscript%3Ealert(1)%3C/script%3E

Seems to not be an issue on master. What version of NodeBB are you running?

@dmyates
Copy link

dmyates commented Feb 17, 2016

Okay, so in many cases just clicking on the link doesn't give you XSS, because your browser automatically URL encodes the angle brackets. But if you click on the link, intercept your request (use Burp Suite or Fiddler or similar) and URL decode the path, it works.

Depending on your deployment of NodeBB's surrounding infrastructure, this decoding may be done at some point before the request hits NodeBB. In those cases this would certainly be an XSS vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants