Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow explicitly "not watching" a topic in an ignored category #5852

Closed
TwelveBaud opened this issue Aug 1, 2017 · 2 comments
Assignees

Comments

@TwelveBaud
Copy link

  • NodeBB version: 1.5.2
  • NodeBB git hash: f59f48c
  • Database type: mongo
  • Database version: unknown

In Discourse, when a category is watched (for notifications) or ignored, all topics created therein are also watched or ignored. You can visit an individual topic and change its visibility rule manually, in which case it follows the new rule instead of the category rule. There was definitely some discoursistency when topics were moved from category to category or when a user changes visibility at the category level, but in general new topics inherited visibility from their parent at time of creation and could be individually changed later.

In NodeBB, categories can be watched (for unread) or ignored, and threads can be watched (for notifications), not watched (follow category rule), or ignored. Category and thread visibility are independent from each other, and the system (in general) feels sane. However, there's one small problem:

If a topic is in an ignored category, the three topic visibility options effectively become watch (for notifications), ignore, ignore. There's no way to configure it to show up in the unread list short of manually clicking "Mark as unread". I could watch the topic, but that starts adding entries to my notifications feed, which I feel should be limited to items personally pertaining to me (mentions, for example). It could be argued that the topic is categorized incorrectly, that if I want it to show up in unread it shouldn't be in a category I ignore, but I can't recategorize threads as an end user, nor would I want to since it's on-topic for that category. It could be argued that I should unignore that category, but most everything in it is stuff I don't care about -- aside from the one or two threads I'm trying to track -- and would blow up my unread box like crazy.

I think the best solution is to extend category visibilities to include watch-for-notifications, default a topic's visibility to null (signalling to use category visibility), and allow a manually-set topic visibility setting to override category visibility entirely. This would provide similar intended behavior to Discourse, without suffering from Discourse's unintended discoursistency.

@julianlam
Copy link
Member

julianlam commented Aug 29, 2017

https://what.thedailywtf.com/post/1218269

(wonder if that will expand...)

That's a bit more difficult to fix as topics are opt-in while categories are opt-out.

We can toss blame around but the reason this is so is because you weren't able to unwatch categories at all, at first.

@barisusakli barisusakli self-assigned this Dec 6, 2017
@barisusakli
Copy link
Member

I was planning on adding watching not watching and ignoring to category settings as per #5172 but even that won't resolve this. The request here is to be able to ignore a category and then change a setting in the topic visibility so that it shows on /unread but replies don't generate a notification. I don't think this is possible without a 4th option in the topic dropdown.

Watching - show in /unread, notify me of new replies
Tracking - show in /unread, don't notify of new replies
Not watching - follow category setting
Ignore - dont show in /unread dont notify of new replies

You seem to be asking for tracking. Which is pretty much what Discourse does.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants