Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread topics list is truncated on Nodebb 1.11.1 #7209

Closed
joolswills opened this issue Jan 8, 2019 · 5 comments
Closed

Unread topics list is truncated on Nodebb 1.11.1 #7209

joolswills opened this issue Jan 8, 2019 · 5 comments
Assignees
Milestone

Comments

@joolswills
Copy link

joolswills commented Jan 8, 2019

  • NodeBB version: 1.11.1
  • NodeBB git hash: 1cdb6af
  • Database type: mongo
  • Database version: 3.4.18
  • Exact steps to cause this issue:
  1. Go to unread topics on my forum https://retropie.org.uk/forum/
  2. scroll down
  3. limited number of topics are shown (for me right now I have 51 unread, but only 21 show)
  • What you expected:
    51 unread topics to be shown if continue to scroll
  • What happened instead:
    only a limited number are shown

I notice that the last commit for 1.11.1 is a backported fix relating to the unread inf scroll. But it doesn't seem to be working on our forum. Multiple users on the forum have reported the issue (https://retropie.org.uk/forum/topic/20349/no-infinite-scrolling-on-unread-section)

@barisusakli
Copy link
Member

Do you get all topics in pagination mode?

@joolswills
Copy link
Author

Yes. Works fine in paginated mode.

@barisusakli barisusakli self-assigned this Jan 8, 2019
@barisusakli barisusakli added this to the 1.12.0 milestone Jan 8, 2019
@joolswills
Copy link
Author

Thanks very much for the fix. Is 1.12 due out soon or could this be merged to 1.11.x?

I can cherry pick in the meantime if it's compatible with the 1.11 base.

@joolswills
Copy link
Author

Ah - you did. Thanks for that :)

@barisusakli
Copy link
Member

No problem, 1.12.0 is waiting for these issues https://github.com/NodeBB/NodeBB/milestones/1.12.0

@julianlam julianlam modified the milestones: 1.12.0, 1.11.2 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants