Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't change user status after logging in #7485

Closed
jessty opened this issue Mar 23, 2019 · 2 comments
Closed

can't change user status after logging in #7485

jessty opened this issue Mar 23, 2019 · 2 comments

Comments

@jessty
Copy link

jessty commented Mar 23, 2019

NodeBB version: latest
NodeBB git hash: latest

  • Exact steps to cause this issue:
    1. First I logged in by password at the page(https://community.nodebb.org/login)
    2. Then, I clicked my avatar at upper right corner
      3. And, I clicked status button to change my status but failed
      4. Last I refreshed the page, clicked status button and changed status successfully
  • What you expected:
    change status without refreshing the page
  • Reason for the problem

in source code: public/src/app.js

The function handleStatusChange binds click listeners on status buttons, and it is excuted once page loaded.
If user isn't logged and accesses pages, there aren‘t status buttons.
Then handleStatusChange fails to bind listeners.
And, the page wouldn't be refreshed after user log in,
So, there still is no listener on status buttons.
Maybe there are some other problems in no refreshing situation.

@psychobunny
Copy link
Contributor

hey, thanks for making a detailed report, which helped me fixed this issue pretty quick (well hopefully) :)

@psychobunny
Copy link
Contributor

updated community.nodebb.org as well, let us know if you can still reproduce :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants