Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont add socket.io adapter if running a single nodebb instance #8474

Closed
barisusakli opened this issue Jul 7, 2020 · 0 comments
Closed

dont add socket.io adapter if running a single nodebb instance #8474

barisusakli opened this issue Jul 7, 2020 · 0 comments
Assignees
@barisusakli
Labels
enhancement
Milestone
1.14.1

Comments

@barisusakli
Copy link
Member

https://github.com/NodeBB/NodeBB/blob/master/src/socket.io/index.js#L30-L36

Seems like at some point this was removed. If clustering isn't used there is no need to add a socket.io-adapter since all clients are on the same nodejs instance.
@barisusakli barisusakli added this to the 1.14.1 milestone Jul 7, 2020
@barisusakli barisusakli self-assigned this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barisusakli barisusakli

Labels
enhancement
Projects
None yet
Milestone
1.14.1
Development

No branches or pull requests
1 participant
@barisusakli