Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting category as a homepage #8757

Closed
cryptoethic opened this issue Oct 12, 2020 · 4 comments
Closed

Selecting category as a homepage #8757

cryptoethic opened this issue Oct 12, 2020 · 4 comments
Assignees
Milestone

Comments

@cryptoethic
Copy link
Contributor

Hey!

There is a bug with selecting category as a homepage:

image

image

Moreover after refreshing settings page we can see Custom homepage with category ID:
image


Temporary solution is to set the homepage category only via ID:
image

Then everything works fine ;-)

In my ACP I can see 404 errors similar to:

/api/category/6&
/category/7&

Maybe there is an error with Uri encoding? Any ideas where to look deeper into it?

Best,
cryptoethic

@barisusakli barisusakli self-assigned this Oct 12, 2020
@barisusakli barisusakli added this to the 1.15.0 milestone Oct 12, 2020
@barisusakli
Copy link
Member

Seems identical to #8168

@cryptoethic
Copy link
Contributor Author

Correct. In current NodeBB we have:
homePageRoute: ((data.homePageRoute === 'custom' ? data.homePageCustom : data.homePageRoute) || '').replace(/^\//, '')

should be like that?

homePageRoute: ((data.homePageRoute === 'custom' ? data.homePageCustom : data.homePageRoute) || '').replace(/^\//, '').replace('/', '/')

@cryptoethic
Copy link
Contributor Author

Thanks ;-)

@barisusakli
Copy link
Member

barisusakli commented Oct 12, 2020

The route was being returned as 'category/6/testing-ground' Pushed the fix to https://community.nodebb.org/ as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants