Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link in topic thumbs #9184

Closed
fgallese opened this issue Jan 10, 2021 · 5 comments
Closed

Wrong link in topic thumbs #9184

fgallese opened this issue Jan 10, 2021 · 5 comments

Comments

@fgallese
Copy link

Hello guys.

Recently we updated to v1.16.1 and noticed an issue with topic thumbs. For some reason, the link to the image is formed wrong, like this:

[OUR_FORUM_ADDRESS][IMGUR_LINK]

Example: https://forobolso.uy/forohttps://i.imgur.com/KannW8J.jpg where https://forobolso.uy/foro is OUR_FORUM_ADDRESS and https://i.imgur.com/KannW8J.jpg is the IMGUR_LINK of the thumb.

This causes a 404 on all those images.

See screenshots:
Screenshot from 2021-01-10 04-56-42

Screenshot from 2021-01-10 04-56-58

We use the imgur plugin, and this looks super related to that, but we haven't touched anything there and it was working fine up to the nodebb upgrade.

Do you have any ideas what might be happening here ?

Thank you in advance for your usual help !

@barisusakli
Copy link
Member

I think this is happening because the relative path /foro is being prepended to the image url here NodeBB/nodebb-theme-persona@b3e8e8f.

@fgallese Can you revert that commit and try again?

@fgallese
Copy link
Author

@barisusakli indeed, reverting that fixed it ! Thank you.

@julianlam
Copy link
Member

@fgallese Apologies for this, I will commit a proper fix to this shortly, but I am glad to hear that the revert helped your site 😄

@julianlam julianlam added this to To do in Topic Thumbnail Refactor via automation Jan 11, 2021
@julianlam julianlam moved this from To do to Done in Topic Thumbnail Refactor Jan 11, 2021
@julianlam
Copy link
Member

@fgallese Would appreciate if you could try the latest master and report back as to whether the thumbnails continue to be properly served 😄

@fgallese
Copy link
Author

Just tested it with master, it works perfectly fine 👍🏻
Thank you, I appreciate the quick answer and solution to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants