Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paste-to-upload permissions and Edge support #53

Merged
merged 2 commits into from Jul 12, 2016
Merged

Fix paste-to-upload permissions and Edge support #53

merged 2 commits into from Jul 12, 2016

Conversation

BenLubar
Copy link
Contributor

No description provided.

@julianlam
Copy link
Member

LGTM. Awaiting signoff from @barisusakli

@BenLubar BenLubar changed the title Fix paste-to-upload permissions and Firefox support Fix paste-to-upload permissions and Edge support Jul 12, 2016
@julianlam julianlam added the bug label Jul 12, 2016
@BenLubar
Copy link
Contributor Author

I misremembered which browser had the problem with file.name. Firefox is still broken, but at least Edge works.

@@ -257,6 +258,10 @@ define('composer/uploads', [
uploads.inProgress[post_uuid] = uploads.inProgress[post_uuid] || [];
uploads.inProgress[post_uuid].push(1);

if (params.formData) {
params.formData.append('cid', cid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? cid is already passed in the data below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind saw the other issue.

@barisusakli barisusakli merged commit a2dbd83 into NodeBB:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants