Display breadcrumbs on topic page #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barisusakli, any reason to not merge this? Thanks! |
|
@saikarthikp9 we are discussing how to handle this, the default breadcrumb design has some issues. It duplicates the same data and wastes even more vertical space.
|
barisusakli
added a commit
that referenced
this pull request
Feb 29, 2024
commit a1d72e6 Author: Barış Soner Uşaklı <barisusakli@gmail.com> Date: Thu Feb 29 13:09:36 2024 -0500 1.2.33 commit 38fece2 Author: Barış Soner Uşaklı <barisusakli@gmail.com> Date: Thu Feb 29 13:08:51 2024 -0500 add breadcrumbs option, closes #34 commit 01f00b6 Author: Barış Soner Uşaklı <barisusakli@gmail.com> Date: Wed Feb 28 11:40:41 2024 -0500 1.2.32 commit 7033173 Author: Barış Soner Uşaklı <barisusakli@gmail.com> Date: Wed Feb 28 11:40:21 2024 -0500 moved to core
|
@saikarthikp9 this is now a setting in the theme settings page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added breadcrumbs to the topic page. Was there a reason why this was omitted?
We can add it as a harmony theme setting in ACP, if preferred.