Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed navbar autohide after viewport resize #393

Merged
merged 3 commits into from Dec 21, 2017
Merged

Fixed navbar autohide after viewport resize #393

merged 3 commits into from Dec 21, 2017

Conversation

penicholson
Copy link
Contributor

@pitaj
Copy link
Contributor

pitaj commented Dec 17, 2017

I'm pretty sure there's a CSS fix for this. Would go something like:

  • Always enable the autohiding
  • Use CSS to disable to autohiding when applicable

@pitaj
Copy link
Contributor

pitaj commented Dec 17, 2017 •
edited

I'm also very hesitant to add resize handlers, especially running getBootstrapEnvironment on every resize. getBootstrapEnvironment is a very slow operation, running it on every resize results in a huge lag.

@penicholson
Copy link
Contributor Author

That's a good point, I have done as you suggested in my latest commit. What do you think?

@pitaj
Copy link
Contributor

pitaj commented Dec 18, 2017

It looks good to me but I'll have to test it tonight.

@pitaj pitaj merged commit cbfc3ab into NodeBB:master Dec 21, 2017
julianlam added a commit that referenced this pull request Jan 16, 2018
@julianlam
Fixing #401
3f43ec1 
Resolving regression caused by #393, and re-introduced original
resize handler method used by @petergood -- placing it behind
lodash .debounce should appease @pitaj's concerns, but I frankly
see no other way to have this feature but also fix cases where
the header is not at the top of the page.
tdawgtimmy pushed a commit to EnContext/nodebb-theme-encontext that referenced this pull request Mar 19, 2021
@pitaj
Merge pull request NodeBB#393 from petergood/master
45a53e5 
Fixed navbar autohide after viewport resize
tdawgtimmy pushed a commit to EnContext/nodebb-theme-encontext that referenced this pull request Mar 19, 2021
@julianlam
Fixing #401
e81fd76 
Resolving regression caused by NodeBB#393, and re-introduced original
resize handler method used by @petergood -- placing it behind
lodash .debounce should appease @pitaj's concerns, but I frankly
see no other way to have this feature but also fix cases where
the header is not at the top of the page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@penicholson @pitaj