Remove hardcoded 70px body padding #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body element This also has the nice side effect of simplifying a lot of the panel-offset styling
julianlam
force-pushed
the
no-body-padding
branch
from
84c450d
to
f6f6768
Compare
barisusakli
added a commit
that referenced
this pull request
Apr 28, 2022
* webpack changes * refactor: remove 500-embed.tpl * fix: admin script * chore: up compat * refactor: remove pulling js from modules * fix: unintentional padding in notification dropdown elements/lists * revert: zero-out padding in notifications-list (wrong element selector) * fix: no padding in notification-list dropdown * refactor: notifications dropdown to use flexbox, fixes NodeBB/NodeBB#10284 * fix: NodeBB/NodeBB#10351, refactor chats menu and dropdown to use flexbox as well this also fixes the regression caused by NodeBB/NodeBB#10284 * fix: incorrect default panel-offset * fix: wonky margins on chat list * fix: NodeBB/NodeBB#10363, more timestamp oddities * Remove hardcoded 70px body padding (#547) * fix: NodeBB/NodeBB#10476, eliminate the hardcoded 70px padding in the body element This also has the nice side effect of simplifying a lot of the panel-offset styling * fix: adjust topic header distance from top of page * style: fix spacing * feat: save panelOffset into localStorage, read by core * fix: hide post-tools dropdown menu by default, made visible when menu options are loaded (see NodeBB/NodeBB@690ec2d59 Co-authored-by: Julian Lam <julian@nodebb.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.