Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mobile menus not working after manual page refresh #548

Conversation

sweetppro
Copy link

fix for the mobile menus not working after a manual page reload
as noted here:
https://community.nodebb.org/topic/16467/v2-0-custom-persona-theme-mobile-problems/8

fix for the mobile menus not working after a manual page reload
@sweetppro sweetppro changed the title Update persona.js fix mobile menus not working after manual page refresh May 8, 2022
cleanup PR
@julianlam
Copy link
Member

Hi @sweetppro—I've reviewed the context, but this fix will not work. There was a reason why it was put behind the action:app.load callback.

Specifically to your debugging, however, 2286.ab7f70f35005dbd282bd.min.js this looks like CloudFlare Rocket Loader.

Can you turn it off? NodeBB should work fine with it, but sometimes Rocket Loader is too smart for its own good.

@julianlam julianlam closed this May 9, 2022
@sweetppro
Copy link
Author

sweetppro commented May 9, 2022

@julianlam Rocket loader is disabled, but brotli and autominify are enabled. I can test options when I get home

@sweetppro
Copy link
Author

@julianlam I disabled Auto minify for javascript and CSS, I also disabled Brotli. Rocket Loader has been disabled in my site since 2017 (it was causing issues with other apps I run). I also tried changing the caching level to No query string and Ignore query string.

I even disabled CloudFlare by putting it in development mode.

The only way the menus reliably work on my site is with this PR...

Do you have any other suggestions?

@julianlam
Copy link
Member

Sorry for the delay -- so even with the auto minify disabled, you're still seeing that kind of file?

Let me put it behind a hooks call... then you can try again.

@sweetppro
Copy link
Author

@julianlam yup,
the only way to get it working on my site was via #550

@julianlam
Copy link
Member

Can you try with v12.0.4 of Persona?

@julianlam
Copy link
Member

@sweetppro Ah, sorry, I did not see your new PR. Give mine a try first, and see? Listening for widget load seems unrelated, but worth investigating if my fix doesn't work.

@sweetppro
Copy link
Author

sweetppro commented May 20, 2022

@julianlam yup, your fix in v12.0.4 works great!
👍

@julianlam
Copy link
Member

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants