-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mobile menus not working after manual page refresh #548
fix mobile menus not working after manual page refresh #548
Conversation
fix for the mobile menus not working after a manual page reload
cleanup PR
Hi @sweetppro—I've reviewed the context, but this fix will not work. There was a reason why it was put behind the Specifically to your debugging, however, Can you turn it off? NodeBB should work fine with it, but sometimes Rocket Loader is too smart for its own good. |
@julianlam Rocket loader is disabled, but brotli and autominify are enabled. I can test options when I get home |
@julianlam I disabled Auto minify for javascript and CSS, I also disabled Brotli. Rocket Loader has been disabled in my site since 2017 (it was causing issues with other apps I run). I also tried changing the caching level to I even disabled CloudFlare by putting it in development mode. The only way the menus reliably work on my site is with this PR... Do you have any other suggestions? |
Sorry for the delay -- so even with the auto minify disabled, you're still seeing that kind of file? Let me put it behind a hooks call... then you can try again. |
@julianlam yup, |
Can you try with v12.0.4 of Persona? |
@sweetppro Ah, sorry, I did not see your new PR. Give mine a try first, and see? Listening for widget load seems unrelated, but worth investigating if my fix doesn't work. |
@julianlam yup, your fix in v12.0.4 works great! |
Excellent! |
fix for the mobile menus not working after a manual page reload
as noted here:
https://community.nodebb.org/topic/16467/v2-0-custom-persona-theme-mobile-problems/8