Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS origin #118

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Add CORS origin #118

merged 2 commits into from
Mar 17, 2020

Conversation

morrigan
Copy link
Member

No description provided.

@morrigan morrigan requested a review from mpetrunic March 17, 2020 18:13
src/App.ts Outdated
@@ -57,7 +57,12 @@ export class App implements Service {
const router = Router();
if (config.env === "dev") {
router.use(cors() as any);
} else {
router.use(cors({
origin: "https://analytics.hactar.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV VARIABLE, so I can change it.
I think it's without https anyways

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs use http soo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in ENV, try with https first, gogogog

@morrigan morrigan requested a review from mpetrunic March 17, 2020 18:37
@mpetrunic mpetrunic merged commit 57c643e into master Mar 17, 2020
@mpetrunic mpetrunic deleted the fix/cors-origin branch March 17, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants