Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coverage settings #23

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Update coverage settings #23

merged 2 commits into from
Jan 24, 2020

Conversation

morrigan
Copy link
Member

No description provided.

@morrigan morrigan added bug Something isn't working P4 - Very low Very low priority labels Jan 15, 2020
MakMuftic
MakMuftic approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👍 Probably we should replace all yarn run for yarn inside package.json for consistency?

@morrigan
Copy link
Member Author

@MakMuftic I don't think it works well since reported coverage for the PR is 0% for some reason. Yes, will keep consistency.

@morrigan
Copy link
Member Author

Oh, nice find @MakMuftic ! Seems like it's good now 👏

@morrigan morrigan merged commit c3f4a98 into master Jan 24, 2020
@morrigan morrigan deleted the feature/ci-setup branch January 24, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working P4 - Very low Very low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morrigan @MakMuftic