Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass logger instance to tx monitor #21

Merged
merged 8 commits into from
Oct 21, 2020

Conversation

mpetrun5
Copy link
Member

  • pass logger instance to tx monitor

Closes: #16

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

src/logger.ts Outdated Show resolved Hide resolved
test/monitorService.test.ts Outdated Show resolved Hide resolved
src/logger.ts Outdated
error(...params: any): any;
import debug from "debug";

export interface ILogger<IReturn = void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface ILogger<IReturn = void> {
export interface ILogger<TReturn = void> {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooups

src/logger.ts Outdated Show resolved Hide resolved
@mpetrunic mpetrunic merged commit 442f98b into master Oct 21, 2020
@mpetrunic mpetrunic deleted the mpetrun5/pass-logger-instance-to-tx-monitor branch October 21, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass custom logger instance to transaction monitor
2 participants