Improve the support of unix socket

[jackhftang]

I noted the issue #204. But, I got an error using redis.createClient('/tmp/redis.sock'). Not sure if this is because the interface of net.createConnection() changed.

Anyway, IMHO, unix socket is a useful feature that need to be there. It provides better isolation, faster performance. And yet this is not that much of work.

I removed client.host and client.port, because they do not fit for unix socket.
And add client.address and client.connectionOption. The former is better to reference addres and the later to reference the way to create connection.

I also added new test case UNIX_SOCKET and updated the testcase CHECK_LIST. This pull request pass all test cases.

Finally, README is updated.

[jackhftang]

By the way, it seems to overrlap/fix with issues
issue #632
pull #638
pull #639
pull #625

[brycebaril]

This is awesome! Very complete w/ tests and docs. Releasing as 0.12.0 imminently.

[brycebaril]

Oops, typo here that breaks tests on older versions of Redis. I'll take care of this before I release.

[brycebaril]

Thanks! Published as 0.12.0

[jackhftang]

This is my careless. I just saw a lot createClient(null,null, {...}) in test cases. I didn't understand the purpose of this and think this is ugly, so I didn't write in README. Actually, in order to be backward compatible, I did handle createClient(null,null,{...}) , but didn't know I need to include createClient(undefined, undefined,{...}) also.

Solution 1

Adding typeof arg0 === 'undefined' && typeof arg1 === 'undefined' in last case can handle development situation, but one must provide both PORT and HOST. This is not fully backward-compatible.

Solution 2

Don't throw Error('unknown type of connection in createClient()') in else case, default to create(arg0 || default_port, arg1 || default_host, arg2). This should be fully backward-compatible.

Solution 3

separate and expose createClientUnix and createClientTcp. Don't unify the creation of unix and tcp socket. No ambiguous.

Solution 4

Remain unchanged. Then one need to write something like this.

var port = process.env.PORT || 6379;
var host = process.env.HOST || '127.0.0.1';
var client = createClient(port,host)

Personally, i prefer solution 1. As solution 2 adding support to something like createClient('3000',undefined) and create(undefined, 'localhost') are too vague.

Let me know which do you prefer. I am happy to submit pull request. =]