added URL support to createClient

[kuwabarahiroshi]

Hi,

I thought it would be useful if we could specify redis server with URL string, like below:

// specify remote redis service.
require('redis').createClient('redis://user:password@redis-service.com:6379/');

// or we can also specify localhost.
require('redis').createClient('//localhost:6379');

This overloaded interface would be useful especially for node apps hosted on heroku, on which redis add-ons is usually provided via ENV variable.

require('redis').createClient(process.env.REDISTOGO_URL);

[kuwabarahiroshi]

I remind you guys with indignation! 😃

[tkazec]

Yes please! 👍

[jrf0110]

+1

[rbvea]

+1

[thom4parisot]

Is there any blocker to merge that PR?

[jonathanong]

👍

[blainsmith]

Yeah, would love to have this merged!

[jonathanong]

PING @mranney @brycebaril

[danishin]

+1

[mcwhittemore]

+1

[hunterloftis]

+1

[angelxmoreno]

👍 need this

[angelxmoreno]

wow,just noticed this was posted a while back and it is still open. Any chance we can get some feedback on this so that we are not waiting 10 months on an open ticket?

If the feature is not welcomed then we can post a gist of simple alternative. If it is welcomed then I am sure @kuwabarahiroshi can do a pull+rebase since his PR is now behind master.

[erinishimoticha]

I don't see any problems. If the unix socket test is passing (and it is), this should be merged. I'll merge it if we don't get any negative feedback soon.

[mranney]

Wow, so many +1's. I'm so sorry that I haven't been spending time on this project lately. Please @erinspice make it happen, and if other people want commit access, I'll add you.

[erinishimoticha]

You got it, @mranney!

[angelxmoreno]

you guys rock

[erinishimoticha]

Tip your waiters and waitresses! I'm here all night!

[kuwabarahiroshi]

Thanks for merging!
I'm glad that I could contribute such an awesome project.

[thom4parisot]

\o/ :sparkles: thank you :-)