added commands for Redis 5 rc1 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this be merged soon? Waiting to use the new stream methods in node. |
|
@chenosaurus You can use it now with |
stipsan
pushed a commit
to stipsan/ioredis-mock
that referenced
this pull request
Jun 23, 2018
…449) Support basic stream operations (https://redis.io/topics/streams-intro) for the upcoming Redis 5 release. Some features are missing, such as consumer groups, capped streams or some of the auxiliary commands. Event ids are auto incremented integers in the form of `1-0`, `2-0`, etc. Events are stored internally as an array of arrays and for every event an additional record is kept whether the event has been already polled or not. ``` const redis = new MockRedis({ mystream: [ ["1-0", ["key1", "val1", "key2", "val2"]], ["2-0", ["key1", "val1", "key2", "val2"]] ], "stream:mystream:1-0": {polled: false}, "stream:mystream:2-0": {polled: false}, }) ``` To poll events in a blocking manner is supported and the poll happens every 100ms. ``` // This will resolve once a new event becomes available. redis.xread("BLOCK", "0", "STREAMS", "mystream", "$").then(console.log); // After 1 second add a new event, that will resolve the waiting `XREAD` // command. setTimeout(() => redis.xadd("mystream", "*", "key", "val"), 1000); ``` `ioredis` doesn't support Redis streams yet, but there is [pull request for `redis-commands`](NodeRedis/redis-commands#20) to add support. In the meantime `ioredis`' `createBuiltinCommand` can be used to add support manually: ``` import Redis from "ioredis"; const {string: xadd} = Redis.prototype.createBuiltinCommand("xadd"); const {string: xread} = Redis.prototype.createBuiltinCommand("xread"); Redis.prototype.xadd = xadd; Redis.prototype.xread = xread; const redis = new Redis(); ```
stipsan
added a commit
to stipsan/ioredis-mock
that referenced
this pull request
Jun 23, 2018
## Added ### `xadd`, `xlen`, `xrange`, `xrevrange` and `xread` for stream support (#449 @critocrito) Support basic stream operations (https://redis.io/topics/streams-intro) for the upcoming Redis 5 release. Some features are missing, such as consumer groups, capped streams or some of the auxiliary commands. Event ids are auto incremented integers in the form of `1-0`, `2-0`, etc. Events are stored internally as an array of arrays and for every event an additional record is kept whether the event has been already polled or not. ``` const redis = new MockRedis({ mystream: [ ["1-0", ["key1", "val1", "key2", "val2"]], ["2-0", ["key1", "val1", "key2", "val2"]] ], "stream:mystream:1-0": {polled: false}, "stream:mystream:2-0": {polled: false}, }) ``` To poll events in a blocking manner is supported and the poll happens every 100ms. ``` // This will resolve once a new event becomes available. redis.xread("BLOCK", "0", "STREAMS", "mystream", "$").then(console.log); // After 1 second add a new event, that will resolve the waiting `XREAD` // command. setTimeout(() => redis.xadd("mystream", "*", "key", "val"), 1000); ``` `ioredis` doesn't support Redis streams yet, but there is [pull request for `redis-commands`](NodeRedis/redis-commands#20) to add support. In the meantime `ioredis`' `createBuiltinCommand` can be used to add support manually: ``` import Redis from "ioredis"; const {string: xadd} = Redis.prototype.createBuiltinCommand("xadd"); const {string: xread} = Redis.prototype.createBuiltinCommand("xread"); Redis.prototype.xadd = xadd; Redis.prototype.xread = xread; const redis = new Redis(); ```
|
Would be nice if this could be merged.
|
BridgeAR
approved these changes
Jul 2, 2018
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis 5.0 RC-1 was released on Tuesday. This release includes new sorted set and stream commands.