fix(pallet-allocations): fix try-runtime and the migration code #643
Conversation
Remove the attempt to remove CoinsConsumed which was already removed in a previous deployment of release 2.0.21. Fix the try-runtime test which could have indicated this error to us before merging the migration code.
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 88.47% 88.66% +0.18%
==========================================
Files 35 35
Lines 6292 6279 -13
==========================================
Hits 5567 5567
+ Misses 725 712 -13
Continue to review full report at Codecov.
|
…r own way of tests through the try-runtime feature
| V0_0_0Legacy, // To handle Legacy version | ||
| V2_0_21, | ||
| V0, // Legacy version | ||
| V1, // Adds storage info |
There was a problem hiding this comment.
Is it not right way to enumerate by Pallet version ?
There was a problem hiding this comment.
The think is it's hard to aim at a release version inside the code. For example, here 2.0.21 is already released but this code implies the change should have been part of that.
|
|
||
| #[cfg(feature = "try-runtime")] | ||
| use crate::BalanceOf; | ||
| pub fn on_runtime_upgrade<T: Config>() -> Weight { |
There was a problem hiding this comment.
Can we take this as suggested migration immplementation pattern and apply to other PR's ?
Remove the attempt to remove CoinsConsumed which was already removed in a previous deployment of release 2.0.21. Fix the try-runtime test which could have indicated this error to us before merging the migration code.