XCM Integration #687
XCM Integration #687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 77.75% 77.73% -0.03%
==========================================
Files 42 43 +1
Lines 7594 7596 +2
==========================================
Hits 5905 5905
- Misses 1689 1691 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Alex Sedighi <alex@nodle.com>
|
@Hounsette can you please check if we need to unify the xcm configuration for dmp in pallets_parachain.rs with the one for xcmp in xcm_config.rs. |
It might be cleaner if we merge the xcm_executor and queue configuration. I will do it |
Moved and merged xcm executor configuration from pallet_parachain.rs to xcm_config.rs Add xcmqueue for outbound and messagehandler for pallet parachain system
| type LocationInverter = LocationInverter<Ancestry>; | ||
| type Origin = Origin; | ||
| type Call = Call; | ||
| const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; |
There was a problem hiding this comment.
What is the significance of 100? Why not 50 or 200? Have you compared this param in different parachains?
There was a problem hiding this comment.
There is a reference here as to why the value is 100. It seems to be set the same by 4 parachains that I have checked
There was a problem hiding this comment.
@Hounsette I couldn't find anything related to the version discovery in the link that you have refrenced. If you could clarify it a bit more here, it could be a good to have it as a reference. But I'm not going to hold this PR for that.
Co-authored-by: Alex Sedighi <alex@nodle.com>
@ETeissonniere we have done the comparison of the configuration between different other parachain and might require review once the full flow is tested/fine tuned |
Integration and configuration of the pallet xcm to allow cross-chain messaging.