Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCM Integration #687
XCM Integration #687
Changes from all commits
cec3a4e
6b64b3a
cd65e94
8a21976
0b9265b
4315036
2476915
bab97e0
1657ef5
e1b0be5
26c6985
e8ac13c
839da7b
645294a
a9e69df
2429f41
475cacc
bf0e9f1
71112ba
aeb2882
d2208f2
8c45b06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the significance of 100? Why not 50 or 200? Have you compared this param in different parachains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reference here as to why the value is 100. It seems to be set the same by 4 parachains that I have checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hounsette I couldn't find anything related to the version discovery in the link that you have refrenced. If you could clarify it a bit more here, it could be a good to have it as a reference. But I'm not going to hold this PR for that.