Skip to content

Commit

Permalink
Add localized translator name
Browse files Browse the repository at this point in the history
  • Loading branch information
Noisyfox committed May 4, 2019
1 parent 2733a8e commit bf7efe1
Show file tree
Hide file tree
Showing 12 changed files with 93 additions and 10 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -386,4 +386,19 @@ Usually at Documents\\My Games\\FINAL FANTASY XIV - A Realm Reborn and has a nam
<data name="messageWaitKey" xml:space="preserve">
<value>Wait for Keys...</value>
</data>
<data name="translateProviderNameBaidu" xml:space="preserve">
<value>Baidu Translate</value>
</data>
<data name="translateProviderNameGoogleUnofficial" xml:space="preserve">
<value>Google Translate (Unofficial)</value>
</data>
<data name="translateProviderNameMicrosoft" xml:space="preserve">
<value>Microsoft Translator</value>
</data>
<data name="translateProviderNameYandex" xml:space="preserve">
<value>Yandex.Translate</value>
</data>
<data name="translateProviderNameYoudao" xml:space="preserve">
<value>Youdao Translator</value>
</data>
</root>
15 changes: 15 additions & 0 deletions ACT.FFXIVTranslate/ACT.FFXIVTranslate/localization/strings.resx
Expand Up @@ -386,4 +386,19 @@
<data name="messageWaitKey" xml:space="preserve">
<value>等待按键...</value>
</data>
<data name="translateProviderNameBaidu" xml:space="preserve">
<value>百度翻译</value>
</data>
<data name="translateProviderNameGoogleUnofficial" xml:space="preserve">
<value>谷歌翻译(非官方 API)</value>
</data>
<data name="translateProviderNameMicrosoft" xml:space="preserve">
<value>微软翻译</value>
</data>
<data name="translateProviderNameYandex" xml:space="preserve">
<value>Yandex 翻译</value>
</data>
<data name="translateProviderNameYoudao" xml:space="preserve">
<value>有道翻译</value>
</data>
</root>
Expand Up @@ -31,6 +31,8 @@ public virtual bool PreprocessLine(ChattingLine chattingLine)

internal interface ITranslaterProviderFactory
{
string ProviderId { get; }

string ProviderName { get; }

bool SupportAutoDetect { get; }
Expand Down
Expand Up @@ -15,7 +15,7 @@ public TranslateProviderPanel()
{
InitializeComponent();
comboBoxProvider.DisplayMember = nameof(ITranslaterProviderFactory.ProviderName);
comboBoxProvider.ValueMember = nameof(ITranslaterProviderFactory.ProviderName);
comboBoxProvider.ValueMember = nameof(ITranslaterProviderFactory.ProviderId);
comboBoxLangFrom.DisplayMember = nameof(LanguageDef.DisplayName);
comboBoxLangFrom.ValueMember = nameof(LanguageDef.LangCode);
comboBoxLangTo.DisplayMember = nameof(LanguageDef.DisplayName);
Expand Down
Expand Up @@ -69,7 +69,7 @@ public void PostAttachToAct(FFXIVTranslatePlugin plugin)
TranslateLangFrom = langFrom;
TranslateLangTo = langTo;

var factory = AllProviders.First(it => it.ProviderName == provider);
var factory = AllProviders.First(it => it.ProviderId == provider);
var lF = langFrom == LanguageDef.CodeAuto
? null
: factory.SupportedSrcLanguages.First(it => it.LangCode == langFrom);
Expand Down
Expand Up @@ -17,7 +17,9 @@ internal class BaiduTranslateProviderFactory : ITranslaterProviderFactory
LanguageDef.BuildLangFromCulture("ko", "kor"),
}.ToList();

public string ProviderName => "百度翻译";
public string ProviderId => "百度翻译";
public string ProviderName => LocalizationBase.GetString("translateProviderNameBaidu", ProviderId);

public bool SupportAutoDetect => true;
public List<LanguageDef> SupportedSrcLanguages => _allSupportedLanguages;
public List<LanguageDef> SupportedDestLanguages => _allSupportedLanguages;
Expand Down
Expand Up @@ -18,7 +18,8 @@ internal class BingTranslateProviderFactory : ITranslaterProviderFactory
LanguageDef.BuildLangFromCulture("ko"),
}.ToList();

public string ProviderName => "Microsoft Translator";
public string ProviderId => "Microsoft Translator";
public string ProviderName => LocalizationBase.GetString("translateProviderNameMicrosoft", ProviderId);
public bool SupportAutoDetect => true;
public List<LanguageDef> SupportedSrcLanguages => _allSupportedLanguages;
public List<LanguageDef> SupportedDestLanguages => _allSupportedLanguages;
Expand Down
Expand Up @@ -18,7 +18,8 @@ internal class GoogleTranslateProviderFactory : ITranslaterProviderFactory
LanguageDef.BuildLangFromCulture("ko"),
}.ToList();

public string ProviderName => "Google Translate (unofficial)";
public string ProviderId => "Google Translate (unofficial)";
public string ProviderName => LocalizationBase.GetString("translateProviderNameGoogleUnofficial", ProviderId);
public bool SupportAutoDetect => true;
public List<LanguageDef> SupportedSrcLanguages => _allSupportedLanguages;
public List<LanguageDef> SupportedDestLanguages => _allSupportedLanguages;
Expand Down
Expand Up @@ -17,7 +17,8 @@ internal class YandaxTranslateProviderFactory : ITranslaterProviderFactory
LanguageDef.BuildLangFromCulture("ko"),
}.ToList();

public string ProviderName => "Yandex Translate";
public string ProviderId => "Yandex Translate";
public string ProviderName => LocalizationBase.GetString("translateProviderNameYandex", ProviderId);

public bool SupportAutoDetect => true;

Expand Down
Expand Up @@ -16,7 +16,8 @@ internal class YoudaoTranslateProviderFactory : ITranslaterProviderFactory
LanguageDef.BuildLangFromCulture("ko"),
}.ToList();

public string ProviderName => "有道翻译";
public string ProviderId => "有道翻译";
public string ProviderName => LocalizationBase.GetString("translateProviderNameYoudao", ProviderId);
public bool SupportAutoDetect => true;
public List<LanguageDef> SupportedSrcLanguages => _allSupportedLanguages;
public List<LanguageDef> SupportedDestLanguages => _allSupportedLanguages;
Expand Down

0 comments on commit bf7efe1

Please sign in to comment.