Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay is displayed at startup even if "show overlay" is unchecked #14

Closed
Seferex opened this issue Feb 23, 2020 · 4 comments
Closed
Labels

Comments

@Seferex
Copy link

Seferex commented Feb 23, 2020

Hello, first of all thank you so much for all your effort on making this plugin!

When i open ACT, the plugin window will be displayed even if i did untick the "show overlay"... It will disappear if i will tick it on/ff again...
Hope you will fix it on next release!

P.S. Is it possible to have an option for japanese where it shows also the "pronunce"? For example the word こんにちは will be translated to "hello" + "Kon'nichiwa"
Or since it would not be so nice to see, add an option to just show only "hello" or only "Kon'nichiwa".

@Noisyfox
Copy link
Owner

Thanks for you report! I'll make a fix ASAP.

There is a issue (#5) that requests the rōmaji. I'd like to add this however I can't find a free online service that provides this with an easy to use API so I can't give you any promise.

@Noisyfox Noisyfox changed the title Minor problem Overlay is displayed at startup even if "show overlay" is unchecked Feb 23, 2020
@Seferex
Copy link
Author

Seferex commented Feb 23, 2020

Thank you for the quick reply.

I will look for next release ^^ and lets hope you will find a free way to implement the romajis!

Thanks again many and many times for the very nice plugin!

Noisyfox added a commit that referenced this issue Feb 23, 2020
This fixes the issue that overlay is displayed at start up even if "show overlay" is unchecked (#14).
@Noisyfox
Copy link
Owner

Version 1.4.1 has been released that should fix this issue.

@Noisyfox Noisyfox added the bug label Feb 23, 2020
@Seferex
Copy link
Author

Seferex commented Feb 23, 2020

wow! i did not expect such a quick fix!

Thank you a lot! You rock!.

Hope you will find a way to add romajis, then this plugin will be more than perfect! (atm is already 10/10!). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants