Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deref implementation from non-pointer types #220

Open
19 tasks
Tracked by #303
alcuadrado opened this issue Oct 27, 2023 · 0 comments
Open
19 tasks
Tracked by #303

Remove Deref implementation from non-pointer types #220

alcuadrado opened this issue Oct 27, 2023 · 0 comments
Milestone
EDR v0.5.0

Comments

@alcuadrado
Copy link
Member

alcuadrado commented Oct 27, 2023 •
edited by Wodann
Loading

I stumbled upon a Deref implementation in PendingTransaction, and I was told that they should only be used with pointer types. I didn't remove it to avoid generating conflicts, and instead, I'm just opening the issue with a list of the types implementing Deref.

Documentation explaining why Deref and DerefMut should only used for smart pointer.

Definition of Done
Remove occurrences of Deref and DerefMut, wherever possible. A (non-exhaustive) list:

  • ZeroXPrefixedBytes
  • ReceiptLog
  • FullBlockLo
  • TestRpcClient
  • BlockReceipt
  • PendingTransaction
  • MemPool
  • FilterLog
  • State
  • Receipt
  • Blockchain
  • Block
  • EdrContext
  • Config
  • PendingTransaction
  • AccountModifierFn
  • TestForkState
  • TestForkState
  • MineBlockResult
@Wodann Wodann added this to the EDR v0.3.0 milestone Oct 28, 2023
@Wodann Wodann mentioned this issue Feb 26, 2024
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
EDR
Status: Todo
Milestone
EDR v0.5.0
Development

No branches or pull requests
3 participants
@alcuadrado @fvictorio @Wodann