You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I stumbled upon a Deref implementation in PendingTransaction, and I was told that they should only be used with pointer types. I didn't remove it to avoid generating conflicts, and instead, I'm just opening the issue with a list of the types implementing Deref.
Documentation explaining why Deref and DerefMut should only used for smart pointer.
Definition of Done
Remove occurrences of Deref and DerefMut, wherever possible. A (non-exhaustive) list:
ZeroXPrefixedBytes
ReceiptLog
FullBlockLo
TestRpcClient
BlockReceipt
PendingTransaction
MemPool
FilterLog
State
Receipt
Blockchain
Block
EdrContext
Config
PendingTransaction
AccountModifierFn
TestForkState
TestForkState
MineBlockResult
The text was updated successfully, but these errors were encountered:
I stumbled upon a
Deref
implementation inPendingTransaction
, and I was told that they should only be used with pointer types. I didn't remove it to avoid generating conflicts, and instead, I'm just opening the issue with a list of the types implementingDeref
.Documentation explaining why
Deref
andDerefMut
should only used for smart pointer.Definition of Done
Remove occurrences of
Deref
andDerefMut
, wherever possible. A (non-exhaustive) list:ZeroXPrefixedBytes
ReceiptLog
FullBlockLo
TestRpcClient
BlockReceipt
PendingTransaction
MemPool
FilterLog
State
Receipt
Blockchain
Block
EdrContext
Config
PendingTransaction
AccountModifierFn
TestForkState
TestForkState
MineBlockResult
The text was updated successfully, but these errors were encountered: