Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add markdown syntax support - Issue 572 #575

Merged

Conversation

michaeltomasik
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

I added markdown syntax support that was requested based on the description from here #572
I made sure to disable any solidity extension to recreate it
Screenshot 2024-06-05 at 19 24 16

After applying changes, while plugins are disabled

Screenshot 2024-06-05 at 19 24 00

@alcuadrado
Copy link
Member

Can we get this merged, @kanej @OmarTawfik ?

@kanej
Copy link
Member

kanej commented Jun 11, 2024

Can we get this merged, @kanej @OmarTawfik ?

I will take a look.

@kanej kanej merged commit 8190465 into NomicFoundation:development Jun 12, 2024
5 checks passed
@kanej
Copy link
Member

kanej commented Jun 12, 2024

Thanks @michaeltomasik, I was tested locally and merged.

OmarTawfik added a commit to OmarTawfik-forks/hardhat-vscode that referenced this pull request Jun 25, 2024
Update the package version and changelog for the `0.8.4 - 2024-06-24` release.

### Added

- add markdown syntax support ([575](NomicFoundation#575))
- Bump Slang to 0.15.1 ([578](NomicFoundation#578))
OmarTawfik pushed a commit that referenced this pull request Jun 28, 2024
* Add markdown syntax support

* chore: lint fix for package.json

---------

Co-authored-by: Michal Tomasik <michaltomasik@Michals-MacBook-Pro.local>
Co-authored-by: John Kane <john@kanej.me>
OmarTawfik added a commit that referenced this pull request Jun 28, 2024
Update the package version and changelog for the `0.8.4 - 2024-06-24` release.

### Added

- add markdown syntax support ([575](#575))
- Bump Slang to 0.15.1 ([578](#578))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants