Skip to content

Commit

Permalink
Add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
alcuadrado committed Oct 5, 2022
1 parent 6d497ab commit 98e552e
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ export interface ICompilerDownloader {
*/
export class CompilerDownloader implements ICompilerDownloader {
public static getCompilerPlatform(): CompilerPlatform {
// TODO: This check is seriously wrong. It doesn't take into account
// the architecture nor the toolchain. This should check the triplet of
// system instead (see: https://wiki.osdev.org/Target_Triplet).
//
// The only reason this downloader works is that it validates if the
// binaries actually run.
switch (os.platform()) {
case "win32":
return CompilerPlatform.WINDOWS;
Expand Down

0 comments on commit 98e552e

Please sign in to comment.