-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch JsonRPC requests for Websockets #1324
Comments
Hi @Miyou, thanks for letting us know about this. I think a PR would be great, especially if it's not a huge change 🙂 If you do it, please include a way to try it out manually |
Hi @fvictorio. I made a quick and dirty edit that seems to work for at least receiving and executing the array of transactions, but to get them to execute in parallell we would also have to update the EIP1193Provider to also support batch transactions. Here's the edit. It can be tested with the following snippet which works after the edit is applied, but not before: Since this works for now I'll continue with other tasks on my project, but if you are interested I could clean the code up a bit and submit a PR? |
Ugh, I totally missed your response. Sorry about that @Miyou. I can't look at the code in depth right now, but I skimmed it and it looks good. I also tried the command you shared with geth and it worked fine, so I think this is something we want to support too. Feel free to send a PR if you want and have the time! |
…ests via WebSockets
…ests via WebSockets
Fix #1324 (WebSocket BatchRequest) supports Batch requests via WebSockets
We just released this. Thanks! |
Hi. I noticed that batch requests seem to only be supported when using http and not websockets. Looking at handler.ts it seems like a trivial fix. Since I need this for my project I will fork hardhat and implement it. Are you interested in a PR for this?
Search terms: BatchRequest
The text was updated successfully, but these errors were encountered: