Truffle compatibility #6
Comments
fvictorio
pushed a commit
that referenced
this issue
Dec 10, 2020
After the change that moved MiningTimer to HardhatNetworkProvider, interval mining acquires the mutex in require method. As a result, it's sufficient to call and await on any provider method after ticking the sinon clock. They will simply wait on mutex for the mine function to finish.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We should decide which parts of buidler will be compatible with truffle, and why.
My current idea is that buidler should only be compatible enough to make migration from Truffle very easy. I think this is specially important for contracts' tests, which nobody will want to rewrite just to use another tool.
buidler testnow runs truffle-compatible tests, but that ties us to Truffle-contracts, or at least to its APIs. We should consider making explicit what's truffle-compatibility and whats native in buidler, like making those tests runnable withbuidler truffle-test, or even create abuidler-truffleplugin.We also implemented their networks configuration system, which is very focused on web3. Specially the
providerfield is normally used alongweb3-provider-engine, which we want to avoid and may block #5.The text was updated successfully, but these errors were encountered: