Add test block with EIP-2930 tx #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Apr 6, 2021
| // the following methods are copied verbatim from | ||
| // DefaultStateManager | ||
|
|
||
| public isWarmedAddress(address: Buffer): boolean { |
There was a problem hiding this comment.
What about doing return DefaultStateManager.prototype.isWarmedAddress.call(this, address) instead? The same for the rest of the methods.
There was a problem hiding this comment.
Good idea, I'll give it a try.
There was a problem hiding this comment.
Done. Notice that this adds an implicit dependency between those method calls and certain instance variables that have to exist (_accessedStorage and _accessedStorageReverted). tsc doesn't seem to catch those errors.
There was a problem hiding this comment.
Maybe leave a comment? Either thing is dangerous in its own way
There was a problem hiding this comment.
There is one:
// used by the DefaultStateManager calls
private _accessedStorage: Array<Map<string, Set<string>>> = [new Map()];
private _accessedStorageReverted: Array<Map<string, Set<string>>> = [
new Map(),
];
alcuadrado
reviewed
Apr 6, 2021
packages/hardhat-core/test/internal/hardhat-network/provider/node.ts
Outdated
Show resolved
Hide resolved
alcuadrado
reviewed
Apr 6, 2021
|
I left a few small comments, but LGTM |
alcuadrado
reviewed
Apr 6, 2021
packages/hardhat-core/src/internal/hardhat-network/provider/fork/rpcToTxData.ts
Show resolved
Hide resolved
alcuadrado
reviewed
Apr 6, 2021
packages/hardhat-core/src/internal/core/jsonrpc/types/output/transaction.ts
Show resolved
Hide resolved
Co-authored-by: Patricio Palladino <email@patriciopalladino.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RpcTransactiontypeEIP2929StateManagerinterface inForkStateManager