Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused variable #3459

Closed
wants to merge 1 commit into from
Closed

Remove an unused variable #3459

wants to merge 1 commit into from

Conversation

ilovehackathons
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

In JavaScript, the array destructuring syntax allows you to skip variables at certain positions. The variable at position 0 is unused in the code example, therefore it should be skipped.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2022

⚠️ No Changeset found

Latest commit: adf7b27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 23, 2022 at 5:57PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 23, 2022 at 5:57PM (UTC)

@fvictorio
Copy link
Member

Hmm, this makes sense, but I wonder if it wouldn't be better to keep the tutorial simpler since some people reading it might not be super familiar with javascript. What do you think?

@alcuadrado
Copy link
Member

Thanks for submitting this PR, @ilovehackathons! Unfortunately, I think we shouldn't merge it. Here's why:

Hmm, this makes sense, but I wonder if it wouldn't be better to keep the tutorial simpler since some people reading it might not be super familiar with javascript. What do you think?

Agreed with this. As the purpose of the tutorial is educational, the easier it is to understand, the better.

@alcuadrado alcuadrado closed this Feb 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants