Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(clippy): don't lint against deny-by-default clippy lints #4646

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Dec 4, 2023

Something I noticed when adding more Clippy lints to Slang as part of NomicFoundation/slang#155; figured we might as well remove them, since they're in the "correctness" lint group and so probably won't be moved to warn-by-default or even allow-by-default sometime soon.

Copy link

changeset-bot bot commented Dec 4, 2023

⚠️ No Changeset found

Latest commit: c03e1d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview Dec 4, 2023 11:35pm

@Wodann Wodann changed the title chore(clippy): Don't lint against deny-by-default Clippy lints build(clippy): Don't lint against deny-by-default Clippy lints Dec 13, 2023
@Wodann Wodann merged commit f6248d0 into edr/main Dec 13, 2023
32 checks passed
@Wodann Wodann deleted the edr/clippy-lints branch December 13, 2023 19:40
Copy link

gitpoap-bot bot commented Dec 13, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Hardhat Contributor:

GitPOAP: 2023 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@Wodann Wodann changed the title build(clippy): Don't lint against deny-by-default Clippy lints build(clippy): don't lint against deny-by-default clippy lints Dec 13, 2023
@Wodann
Copy link
Collaborator

Wodann commented Dec 13, 2023

Thank you, @Xanewok! 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants