Config loading #5277
Config loading #5277
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| * @param projectName The base name of the folder with the project to use. | ||
| * @param changeDirTo If provided, the working directory will be changed to this. Must be a child of the project folder. | ||
| */ | ||
| export function useFixtureProject(projectName: string, changeDirTo?: string) { |
There was a problem hiding this comment.
@alcuadrado wdyt about having a test module in hardhat-utils for things like this?
There was a problem hiding this comment.
I think it should be a separate package, as it should be a devDependency. I'm planning to add it asap. Before we start repeating ourselves.
| ? configPath | ||
| : resolve(process.cwd(), configPath); | ||
|
|
||
| const { exists } = await import("@nomicfoundation/hardhat-utils/fs"); |
There was a problem hiding this comment.
We can probably use regular imports for the hardhat-utils package, as the package only imports things from node and should be fast enough to avoid using dynamic imports.
There was a problem hiding this comment.
Ignore this comment for now, we'll need more data to decide if and when it is worth using dynamic imports, as most things now will be lazy and wont benefit from using this the pattern.
There was a problem hiding this comment.
This code in particular already existed in the v-next branch, I just moved it from internal/cli/main.ts into here. Definitely something to think about moving forward though.
|
|
||
| const config = imported.default; | ||
|
|
||
| if (typeof config !== "object" || config === null) { |
There was a problem hiding this comment.
@alcuadrado This would allow Array configs to be passed, is that intended? By the way, this is the second time I've seen an isObject check (which is also missing the Array check). I believe we should add this as a util.
There was a problem hiding this comment.
@zoeyTM you can ignore this, I'll put a separate PR adding isObject and replacing the occurrences with the helper.
resolves #5263