Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGlobalParametersMap implementation & testing #5399

Merged
merged 3 commits into from
Jun 19, 2024
Merged

buildGlobalParametersMap implementation & testing #5399

merged 3 commits into from
Jun 19, 2024

Conversation

schaable
Copy link
Member

@schaable schaable commented Jun 15, 2024 •
edited
Loading

Part of #5379

This should be easy to review by going through it commit by commit.

Merge this after #5390

@schaable schaable added the v-next A Hardhat v3 development task label Jun 15, 2024
@schaable schaable self-assigned this Jun 15, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 2:20pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2024

⚠️ No Changeset found

Latest commit: 0e1ba7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 15, 2024
alcuadrado
alcuadrado reviewed Jun 19, 2024
View reviewed changes
v-next/core/src/index.ts
@@ -28,4 +28,4 @@ export async function createHardhatRuntimeEnvironment(
}

export { resolvePluginList } from "./internal/plugins/resolve-plugin-list.js";
export { buildGlobalParameterMap } from "./internal/global-parameters.js";
export { buildGlobalParametersMap } from "./internal/global-parameters.js";
Copy link
Member

@alcuadrado alcuadrado Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schaable We already discussed changing this name in a future PR, but just FYI, this was correct. It can be tricky for us, native Spanish speakers, but it's ParameterMap, not ParametsMap. You have to keep the first word in singular, even though the name represents a collection of those things — pretty much the opposite of what you'd do in Spanish.

alcuadrado
alcuadrado approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's not forget about the naming issue

@schaable schaable mentioned this pull request Jun 19, 2024
Merged
Base automatically changed from global-parameters to v-next June 19, 2024 22:16
@schaable
Copy link
Member Author

LGTM, but let's not forget about the naming issue

I've added an issue to track it.

@schaable schaable merged commit 228fcd1 into v-next Jun 19, 2024
50 checks passed
@schaable schaable deleted the build-global-param branch June 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@schaable schaable

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schaable @alcuadrado