Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test reporter's integration tests more robust across node versions #5423

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

alcuadrado
Copy link
Member

This PR fixes the test runner's integration tests, which had stopped passing with the release of Node v22.3.0.

The reason they were failing was that the stack traces have some references to Node's internals and those change across versions.

This PR removes those references before comparing the expected results.

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 7:34pm

Copy link

changeset-bot bot commented Jun 22, 2024

⚠️ No Changeset found

Latest commit: 48f0862

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 22, 2024
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Jun 22, 2024
@alcuadrado alcuadrado merged commit 38b2dc1 into v-next Jun 24, 2024
49 checks passed
@alcuadrado alcuadrado deleted the fix-test-runner-integration-tests branch June 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants