Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod updates #674

Merged
merged 16 commits into from
Mar 21, 2021
Merged

Mod updates #674

merged 16 commits into from
Mar 21, 2021

Conversation

ALongStringOfNumbers
Copy link
Member

A couple mod updates that have come out since the last update PR. The Little Tiles one might need some specific checking.

@ALongStringOfNumbers ALongStringOfNumbers added the enhancement New feature or request label Jan 22, 2021
@ALongStringOfNumbers ALongStringOfNumbers added this to In progress in Nomifactory via automation Jan 22, 2021
@ALongStringOfNumbers ALongStringOfNumbers added this to the 1.3 milestone Jan 22, 2021
@ALongStringOfNumbers ALongStringOfNumbers linked an issue Feb 23, 2021 that may be closed by this pull request
Packaged Auto (and ExCrafting) does not reconnect to the network if broken and re-placed. #513
Closed
@Exaxxion Exaxxion added dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Feb 23, 2021
@Exaxxion
Copy link
Collaborator

Force-push was to separate the LittleTiles/CreativeCore updates into a separate feature branch as those are going to require some more detailed testing, whereas these other mods are anticipated to be safe to update.

@Exaxxion Exaxxion mentioned this pull request Mar 10, 2021
Merged
@Exaxxion
Copy link
Collaborator

This CT update is pretty big news as it should drastically increase recipe lookup performance. Thanks @PrototypeTrousers for reporting CraftTweaker/CraftTweaker#1186 and letting us know about the fix.

@Exaxxion
Copy link
Collaborator

I think we need to hold off on the CEU update for now because it apparently breaks some behaviors our players rely upon. That and some of its behavior changes (which seem like bugs to me) could be rather confusing. See Tictim/CEU#1 for my findings.

Everything else looks good, no problems encountered during testing.

@Exaxxion
Copy link
Collaborator

Exaxxion commented Mar 21, 2021 •
edited
Loading

Force push was to cull the three CEU commits (7901a1e, 8432287, 6a10531) from this feature branch.

Nomifactory automation moved this from In progress to Reviewer approved Mar 21, 2021
@Exaxxion Exaxxion merged commit 5311cc6 into dev Mar 21, 2021
Nomifactory automation moved this from Reviewer approved to Done Mar 21, 2021
@Exaxxion Exaxxion deleted the mod-updates branch March 21, 2021 04:09
@ALongStringOfNumbers ALongStringOfNumbers mentioned this pull request Apr 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exaxxion Exaxxion Exaxxion approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
Nomifactory
  
Done
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Packaged Auto (and ExCrafting) does not reconnect to the network if broken and re-placed.
2 participants
@ALongStringOfNumbers @Exaxxion