Replace MICOM with BLOM #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi Mats,
looks very good to me, it's good to have this done. Just one thing I saw in the iHAMOCC code: It great that the model can read old restart files (with .micom. in the file name). But if PNETCDF is active this seems not to be the case for iHAMOCC (file aufr_bgc.F90)? Do I misunderstand something or is this intentionally?
|
Hi Jörg, This is not intentional and must be corrected in the PR before merging. Thanks for spotting this. |
|
I have updated aufr_bgc.F90 and verified correct restart with PnetCDF enabled. |
JorgSchwinger
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to other pull requests in NorESMhub repositories (NorESM, cime, CAM and CESM_CICE5) to complete the transition from MICOM to BLOM.
I believe the most profound change is that now output and restart files are called *.blom.*.nc compared to *.micom.*.nc before. NorESM can still branch from old experiments using *.micom.*.nc restart files. Other notable changes is that BLOM is placed in the components/blom folder of NorESM and that $DIN_LOC_ROOT/ocn/blom is the root of BLOM input data compared to $DIN_LOC_ROOT/ocn/micom before.