add new sum diagnostics for comparison to oslo-aero #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvertens
changed the title
mvertens
changed the title
gold2718
approved these changes
May 26, 2024
Comment on lines
781
to
786
| ! so4_a1,so4_a2,so4_a3 | ||
| ! bc_a1,bc_a4 | ||
| ! pom_a1,pom_a4 | ||
| ! ncl_a1,ncl_a2,ncl_a3 | ||
| ! soa_a1,soa_a2 | ||
| ! num_a1,num_a2,num_a3,num_a4 |
There was a problem hiding this comment.
I think it would be nice if each of these comments was at the end of a line below (e.g., line 781 would be at the end of line 788).
gold2718
approved these changes
May 27, 2024
gold2718
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Testing:
Successfully ran the aux_cam_noresm test suite on betzy:
feature/noresm2_5_alpha02_v5inhttps://github.com/mvertens/OSLO_AEROnoresm2_5_alpha02_v5_camfixes #144