Modifying directory structure + drop pilot terminology #217

TopRichard · 2024-01-11T12:43:25Z

Trying to get closer to EESSI by modifying the directory structure and applying modifications done in PR 387

nessi-bot · 2024-01-11T12:43:29Z

Instance AWS-MC-NESSI is configured to build:

arch x86_64/generic for repo nessi-2022.11-swl-deb10
arch x86_64/generic for repo nessi-2023.06-cl
arch x86_64/generic for repo nessi-2023.06-swl-deb10
arch x86_64/generic for repo nessi-2023.06-swl-deb11
arch x86_64/intel/skylake_avx512 for repo nessi-2022.11-swl-deb10
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-cl
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb10
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb11
arch x86_64/amd/zen2 for repo nessi-2022.11-swl-deb10
arch x86_64/amd/zen2 for repo nessi-2023.06-cl
arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb10
arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb11
arch aarch64/generic for repo nessi-2022.11-swl-deb10
arch aarch64/generic for repo nessi-2023.06-cl
arch aarch64/generic for repo nessi-2023.06-swl-deb10
arch aarch64/generic for repo nessi-2023.06-swl-deb11

nessi-bot · 2024-01-11T12:43:29Z

Instance eX3-NESSI is configured to build:

arch x86_64/amd/zen2 for repo nessi-2022.11-swl-deb10
arch x86_64/amd/zen2 for repo nessi-2023.06-cl
arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb10
arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb11
arch aarch64/generic for repo nessi-2022.11-swl-deb10
arch aarch64/generic for repo nessi-2023.06-cl
arch aarch64/generic for repo nessi-2023.06-swl-deb10
arch aarch64/generic for repo nessi-2023.06-swl-deb11

nessi-bot · 2024-01-11T12:43:30Z

Instance Saga-NESSI is configured to build:

arch x86_64/intel/cascadelake for repo nessi-2022.11-swl-deb10
arch x86_64/intel/cascadelake for repo nessi-2023.06-cl
arch x86_64/intel/cascadelake for repo nessi-2023.06-swl-deb10
arch x86_64/intel/cascadelake for repo nessi-2023.06-swl-deb11
arch x86_64/intel/skylake_avx512 for repo nessi-2022.11-swl-deb10
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-cl
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb10
arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb11
arch x86_64/intel/broadwell for repo nessi-2022.11-swl-deb10
arch x86_64/intel/broadwell for repo nessi-2023.06-cl
arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb10
arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb11
arch x86_64/generic for repo nessi-2022.11-swl-deb10
arch x86_64/generic for repo nessi-2023.06-cl
arch x86_64/generic for repo nessi-2023.06-swl-deb10
arch x86_64/generic for repo nessi-2023.06-swl-deb11

trz42

Looks mostly good. Left a few comments.

I'm a bit uncertain about the changes related to archdetect. To be on the safe side we would have to build for all architectures we need or at least those that are different from EESSI.

trz42 · 2024-01-15T14:09:42Z

README.md

-Using x86_64/intel/broadwell subdirectory for software layer (HARDCODED)
+Using x86_64/intel/haswell subdirectory for software layer


Maybe (HARDCODED) was wrong? I think, this is just an example output. So maybe good to check what we get on a client, then use that?

trz42 · 2024-01-15T14:12:22Z

README.md

+$ source /cvmfs/software.eessi.io/versions/2023.06/init/bash
+Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!


This is a bit tricky as it is the result of what is in the CVMFS repository. Maybe check what it is now and use that? In case we change the CVMFS repository side, we only need to remember to change it here too.

Check last two commits, keeping it as /cvmfs/pilot.nessi.no results in failing CI tests.

trz42 · 2024-01-15T14:12:37Z

README.md

+Prepending /cvmfs/software.eessi.io/versions/2023.06/software/x86_64/intel/haswell/modules/all to $MODULEPATH...
+Environment set up to use EESSI (2023.06), have fun!
+[EESSI 2023.06] $


This is a bit tricky as it is the result of what is in the CVMFS repository. Maybe check what it is now and use that? In case we change the CVMFS repository side, we only need to remember to change it here too.

trz42 · 2024-01-15T14:15:08Z

init/eessi_defaults

+export EESSI_CVMFS_REPO="${EESSI_CVMFS_REPO_OVERRIDE:=/cvmfs/software.eessi.io}"
+# export EESSI_CVMFS_REPO="${EESSI_CVMFS_REPO_OVERRIDE:=/cvmfs/pilot.nessi.no}"


I think, we need to keep /cvmfs/pilot.nessi.no here.

Keeping /cvmfs/pilot.nessi.no results in failing CI tests, check last two commits.

TopRichard · 2024-01-16T07:32:18Z

When changing the README.md only without the init/eessi_defaults file to default, the CI Tests for consistency of README.md fails with :

Run source init/eessi_defaults
  source init/eessi_defaults
  grep "${EESSI_CVMFS_REPO}" README.md
  shell: /usr/bin/bash -e {0}
Error: Process completed with exit code 1.

trz42

Lets merge it and see if it/what works.

Richard Top added 8 commits January 11, 2024 12:10

modified the EESSI-pilot-install-software.sh

2c6de99

modified the .github/workflows/tests_readme.yml

77d124b

modified the README.md

9e40025

modified the init/Magic_Castle/bash

1bba672

modified the init/bash

586cd9c

modified the init/eessi_defaults

dff5274

modified the init/eessi_environment_variables

baf0cc7

modified the init/minimal_eessi_env

76c9279

TopRichard added the NESSI/2023.06 label Jan 11, 2024

Richard Top added 6 commits January 11, 2024 12:56

modified the load_easybuild_module.sh in PR376

d58436b

added missed modifications

465cdca

changed EB version in .github/workflows/tests_scripts.yml

78de899

applied changes to .github/workflows/tests_scripts.yml

86ffb28

applied changes to .github/workflows/tests_scripts.yml

d675a50

modified PS1 in init/bash

41f8bc6

TopRichard force-pushed the nessi.no-2023.06-Directory-structure branch from 72d8ba1 to 41f8bc6 Compare January 12, 2024 10:44

Richard Top added 3 commits January 12, 2024 13:32

applied changes to run_in_compat_layer_env.sh

5e2bb24

changed to eessi instead of nessi in init/defaults for test

a4a67f5

changed nessi to eessi in README.md

3128322

TopRichard requested a review from trz42 January 15, 2024 08:36

trz42 requested changes Jan 15, 2024

View reviewed changes

reverted to default to check CI workflow results

d7b8f07

reverted init/eessi_defaults to default to check CI workflow results

2596647

trz42 approved these changes Jan 16, 2024

View reviewed changes

trz42 added the sync-with-EESSI label Jan 16, 2024

trz42 merged commit 4ed3a63 into NorESSI:nessi.no-2023.06 Jan 16, 2024
62 of 63 checks passed

trz42 mentioned this pull request Jan 16, 2024

switch back to using archspec #218

Merged

TopRichard mentioned this pull request Jan 17, 2024

Syncing code-base and CVMFS repository with EESSI (January 2024) #223

Open

74 tasks

TopRichard deleted the nessi.no-2023.06-Directory-structure branch January 28, 2024 20:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modifying directory structure + drop pilot terminology #217

Modifying directory structure + drop pilot terminology #217

TopRichard commented Jan 11, 2024 •

edited

Loading

nessi-bot bot commented Jan 11, 2024

nessi-bot bot commented Jan 11, 2024

nessi-bot bot commented Jan 11, 2024

trz42 left a comment

trz42 Jan 15, 2024

trz42 Jan 15, 2024

TopRichard Jan 15, 2024

trz42 Jan 15, 2024

trz42 Jan 15, 2024

TopRichard Jan 15, 2024 •

edited

Loading

TopRichard commented Jan 16, 2024

trz42 left a comment

		Using x86_64/intel/broadwell subdirectory for software layer (HARDCODED)
		Using x86_64/intel/haswell subdirectory for software layer

		$ source /cvmfs/software.eessi.io/versions/2023.06/init/bash
		Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!

		export EESSI_CVMFS_REPO="${EESSI_CVMFS_REPO_OVERRIDE:=/cvmfs/software.eessi.io}"
		# export EESSI_CVMFS_REPO="${EESSI_CVMFS_REPO_OVERRIDE:=/cvmfs/pilot.nessi.no}"

Modifying directory structure + drop pilot terminology #217

Modifying directory structure + drop pilot terminology #217

Conversation

TopRichard commented Jan 11, 2024 • edited Loading

nessi-bot bot commented Jan 11, 2024

nessi-bot bot commented Jan 11, 2024

nessi-bot bot commented Jan 11, 2024

trz42 left a comment

Choose a reason for hiding this comment

trz42 Jan 15, 2024

Choose a reason for hiding this comment

trz42 Jan 15, 2024

Choose a reason for hiding this comment

TopRichard Jan 15, 2024

Choose a reason for hiding this comment

trz42 Jan 15, 2024

Choose a reason for hiding this comment

trz42 Jan 15, 2024

Choose a reason for hiding this comment

TopRichard Jan 15, 2024 • edited Loading

Choose a reason for hiding this comment

TopRichard commented Jan 16, 2024

trz42 left a comment

Choose a reason for hiding this comment

TopRichard commented Jan 11, 2024 •

edited

Loading

TopRichard Jan 15, 2024 •

edited

Loading