Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide schemas as module #665

Merged
merged 14 commits into from
Mar 17, 2023
Merged

provide schemas as module #665

merged 14 commits into from
Mar 17, 2023

Conversation

coderbyheart
Copy link
Member

This exports the protocol schemas as an NPM
module so they can be imported in nRF Asset Tracker
projects that need to send or retrieve messages.

@coderbyheart coderbyheart self-assigned this Mar 16, 2023
@coderbyheart coderbyheart marked this pull request as ready for review March 17, 2023 13:46
@umapraseeda
Copy link
Contributor

There seems to be a doc build error? Docs seem to be not updated in the artifact.

@coderbyheart
Copy link
Member Author

Changes to content are minimal and exact replication of already approved content.

@coderbyheart coderbyheart merged commit a595af4 into saga Mar 17, 2023
@coderbyheart coderbyheart deleted the add-types branch March 17, 2023 16:01
coderbyheart added a commit to NordicSemiconductor/asset-tracker-cloud-aws-js that referenced this pull request Mar 20, 2023
- use [new protocol definitions from docs](NordicSemiconductor/asset-tracker-cloud-docs#665)
- switch to ES modules (Closes #572)
- get rid of fp-ts (makes code too complicated, no clear benefit)
@GilDev
Copy link

GilDev commented Oct 26, 2023

There are still links to the old schemas in the docs.

@coderbyheart
Copy link
Member Author

@GilDev is this a problem for you?

@GilDev
Copy link

GilDev commented Oct 26, 2023

Not directly, it was just for information as some of those links point to 404 errors (for example this one: https://github.com/NordicSemiconductor/asset-tracker-cloud-docs/blob/saga/docs/cloud-protocol/state.reported.schema.json). They could also maybe be outdated at some point compared to the new schemas?

@coderbyheart
Copy link
Member Author

Ah, yes it seems some document does not use a permalink. Can you share which page you found that link on? Thanks!

@GilDev
Copy link

GilDev commented Oct 26, 2023

Sure! The “JSON schema file” hyperlink of the “AWS IoT Device Shadow service and MQTT topics” page contains dead links in the $id and $ref parameters.

These seems to be the only ones I found on this page.

@coderbyheart
Copy link
Member Author

Ah, yes, right! We have that fixed in newer releases, but will fix it for the older branches! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants