Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Switch to ESM #572

Closed
2 of 4 tasks
coderbyheart opened this issue Sep 6, 2021 · 8 comments · Fixed by #1339
Closed
2 of 4 tasks

Switch to ESM #572

coderbyheart opened this issue Sep 6, 2021 · 8 comments · Fixed by #1339
Labels
AWS blocked Issue is blocked released on @switch-to-esm released

Comments

@coderbyheart
Copy link
Member

coderbyheart commented Sep 6, 2021 •
edited
Loading

AWS Lambda does not support ESM, yet. So this is on hold until it's implemented on AWS side.

ESM support in Node.js v14 is here: https://aws.amazon.com/de/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

node-fetch v3
@coderbyheart coderbyheart added the blocked Issue is blocked label Sep 6, 2021
@coderbyheart coderbyheart mentioned this issue Sep 6, 2021
Closed
1 task
@coderbyheart coderbyheart mentioned this issue Nov 29, 2021
Closed
1 task
@coderbyheart coderbyheart self-assigned this Jan 7, 2022
@coderbyheart coderbyheart removed the blocked Issue is blocked label Jan 7, 2022
coderbyheart added a commit to NordicSemiconductor/cloud-aws-package-layered-lambdas-js that referenced this issue Jan 7, 2022
@coderbyheart
feat: switch to ESM and esbuild
969501b 
ESM support is now available on AWS Lambda:
https://aws.amazon.com/de/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

See NordicSemiconductor/asset-tracker-cloud-aws-js#572
@coderbyheart coderbyheart mentioned this issue Jan 7, 2022
Merged
coderbyheart added a commit to NordicSemiconductor/cloud-aws-package-layered-lambdas-js that referenced this issue Jan 7, 2022
@coderbyheart
feat: switch to ESM and esbuild (#380)
193c4a9 
* feat: switch to ESM and esbuild

ESM support is now available on AWS Lambda:
https://aws.amazon.com/de/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

See NordicSemiconductor/asset-tracker-cloud-aws-js#572

Closes #365
coderbyheart added a commit to NordicSemiconductor/cloud-aws-package-layered-lambdas-js that referenced this issue Jan 7, 2022
@coderbyheart
feat: switch to ESM and esbuild (#380)
601727a 
* feat: switch to ESM and esbuild

ESM support is now available on AWS Lambda:
https://aws.amazon.com/de/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

See NordicSemiconductor/asset-tracker-cloud-aws-js#572

Closes #365

BREAKING CHANGE: this requires lambdas to be authored for ESM
coderbyheart added a commit that referenced this issue Jan 7, 2022
@coderbyheart
feat: switch to ESM
90d01a0 
Closes #572
@coderbyheart coderbyheart mentioned this issue Jan 7, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This issue has been resolved in version 32.6.0-switch-to-esm.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

coderbyheart added a commit that referenced this issue Jan 7, 2022
@coderbyheart
feat: switch to ESM
dcaa0bc 
Closes #572
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This issue has been resolved in version 33.0.0-switch-to-esm.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This issue has been resolved in version 33.1.0-switch-to-esm.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderbyheart coderbyheart added the blocked Issue is blocked label Jan 18, 2022
@coderbyheart
Copy link
Member Author

Blocked by ESM lambda not working with layers.

@pfried
Copy link

pfried commented Dec 14, 2022

Hi Markus, I guess you are also still stuck with this? I created an issue here: aws/aws-cdk#23333

@coderbyheart
Copy link
Member Author

A few days ago I started a new CDK TypeScript project and think we are now good to move to ESM: see #1185.

I have not observed the problem that you describe in your issue with having to maintain multiple tsconfig files.

@pfried
Copy link

pfried commented Dec 14, 2022

Great! I will take a look

@coderbyheart coderbyheart removed their assignment Jan 23, 2023
@coderbyheart coderbyheart mentioned this issue Mar 20, 2023
Merged
coderbyheart added a commit that referenced this issue Mar 20, 2023
@coderbyheart
feat: use shared types from docs (#1339)
ec0e3b1 
- use [new protocol definitions from docs](NordicSemiconductor/asset-tracker-cloud-docs#665)
- switch to ES modules (Closes #572)
- get rid of fp-ts (makes code too complicated, no clear benefit)
@github-actions
Copy link

🎉 This issue has been resolved in version 40.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AWS blocked Issue is blocked released on @switch-to-esm released
Projects
nRF Asset Tracker Development
Archived in project
Milestone
No milestone
2 participants
@coderbyheart @pfried